Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag les features d'export pour les billets #6197

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Flag les features d'export pour les billets #6197

merged 4 commits into from
Mar 7, 2022

Conversation

artragis
Copy link
Member

Le but est ici de flagger les exports pour qu'en cas de future faille de sécu on ait juste à changer de la conf pour les désactiver.

Je mettrai de la doc si le concept vous plait.

Situphen
Situphen reviewed Oct 23, 2021
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'approuve l'idée. Ça ne mange pas beaucoup de pain et ce serait d'une grande utilité si on découvre de nouvelles failles.

zds/tutorialv2/publication_utils.py Outdated Show resolved Hide resolved
zds/tutorialv2/publication_utils.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 24, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 87.323% when pulling e5d669c on artragis:flag_feature into 203e069 on zestedesavoir:dev.

@Arnaud-D Arnaud-D added the hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest label Nov 1, 2021
Situphen
Situphen requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je propose ce changement pour pouvoir modifier simplement la configuration Ansible et ne pas toucher à /opt/zds/app.

zds/settings/abstract_base/zds.py Outdated Show resolved Hide resolved
artragis and others added 2 commits March 7, 2022 20:22
@artragis @Situphen
Update zds/settings/abstract_base/zds.py
d5f6ac8 
Co-authored-by: Situphen <Situphen@users.noreply.github.com>
@Situphen
Merge branch 'dev' into flag_feature
e5d669c
Situphen
Situphen approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK

@Situphen Situphen merged commit 0035c93 into zestedesavoir:dev Mar 7, 2022
@artragis artragis deleted the flag_feature branch March 8, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Situphen Situphen Situphen approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artragis @coveralls @Situphen @Arnaud-D